linux-kernel - Re: [PATCH v2] fcntl: don't cap l_start and l_end values for F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171117184142.GA28617@lst.de>
Date:   Fri, 17 Nov 2017 19:41:42 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org, Vitaly Lipatov <lav@...rsoft.ru>,
        hch@....de, bfields@...ldses.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fcntl: don't cap l_start and l_end values for
        F_GETLK64 in compat syscall

On Wed, Nov 15, 2017 at 01:03:45PM -0500, Jeff Layton wrote:
> From: Jeff Layton <jlayton@...hat.com>
> 
> Currently, we're capping the values too low in the F_GETLK64 case. The
> fields in that structure are 64-bit values, so we shouldn't need to do
> any sort of fixup there.
> 
> Make sure we check that assumption at build time in the future however
> by ensuring that the sizes we're copying will fit.
> 
> With this, we no longer need COMPAT_OFF_T_MAX either, so remove it.

Sounds like the COMPAT_LOFF_T_MAX should be a separate patch, but otherwise
this looks good.

Reviewed-by: Christoph Hellwig <hch@....de>

Btw, I seems like arm has another copy of the old broken compat
code in arch/arm/kernel/sys_oabi-compat.c.  I wonder if anyone with
a vested interest in arm would be willing to clean that mess up.