linux-kernel - Re: [PATCH 2/4] drm: amd: Fix line continuation formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_MHhjMmeuazwmZg9VUtG=PNTG85GRmfS-m9_t9kdam+wQ@mail.gmail.com>
Date:   Fri, 17 Nov 2017 14:52:45 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Harry Wentland <harry.wentland@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Christian König <christian.koenig@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 2/4] drm: amd: Fix line continuation formats

On Thu, Nov 16, 2017 at 10:50 AM, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote:
>> On 2017-11-16 10:27 AM, Joe Perches wrote:
>> > Line continuations with excess spacing causes unexpected output.
> []
>> > @@ -872,9 +870,8 @@ static bool perform_clock_recovery_sequence(
>> >     if (retry_count >= LINK_TRAINING_MAX_CR_RETRY) {
>> >             ASSERT(0);
>> >             dm_logger_write(link->ctx->logger, LOG_ERROR,
>> > -                   "%s: Link Training Error, could not \
>> > -                    get CR after %d tries. \
>> > -                   Possibly voltage swing issue", __func__,
>> > +                   "%s: Link Training Error, could not get CR after %d tries. Possibly voltage swing issue",
>>
>> Would probably be good to add a '\n' here as well but that's not the main intention of this patch.
>
> About 1/4 of the dm_logger_write calls are missing
> newlines and I think it should be a separate patch.
>
> I encourage you to fix them one day.
>
>> Reviewed-by: Harry Wentland <harry.wentland@....com>
>
> cheers, Joe

Applied.  Thanks!

Alex