linux-kernel - Re: [PATCH 07/10] Input: sun4i-ts: Handle return value of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171117195600.a3eiaflvifqwtopr@dtor-ws>
Date:   Fri, 17 Nov 2017 11:56:00 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     maxime.ripard@...e-electrons.com, wens@...e.org,
        linux@...ck-us.net, wsa@...-dreams.de, daniel.thompson@...aro.org,
        mcuos.com@...il.com, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 07/10] Input: sun4i-ts: Handle return value of
 platform_get_irq

On Sat, Nov 18, 2017 at 12:45:29AM +0530, Arvind Yadav wrote:
> platform_get_irq() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/input/touchscreen/sun4i-ts.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c
> index d2e14d9..2753fd3 100644
> --- a/drivers/input/touchscreen/sun4i-ts.c
> +++ b/drivers/input/touchscreen/sun4i-ts.c
> @@ -315,6 +315,9 @@ static int sun4i_ts_probe(struct platform_device *pdev)
>  		return PTR_ERR(ts->base);
>  
>  	ts->irq = platform_get_irq(pdev, 0);
> +	if (ts->irq < 0)

ts->irq is unsigned, you need to change it or use a temporary
(preferable).

> +		return ts->irq;
> +
>  	error = devm_request_irq(dev, ts->irq, sun4i_ts_irq, 0, "sun4i-ts", ts);
>  	if (error)
>  		return error;
> -- 
> 2.7.4
> 

Thanks.

-- 
Dmitry