linux-kernel - Re: [PATCH V6] clk: qcom: Add spmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2017 14:22:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Tirupathi Reddy <tirupath@...eaurora.org>
Cc:     sboyd@...eaurora.org, mturquette@...libre.com,
        mark.rutland@....com, andy.gross@...aro.org,
        david.brown@...aro.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org
Subject: Re: [PATCH V6] clk: qcom: Add spmi_pmic clock divider support

On Fri, Nov 17, 2017 at 03:18:47PM +0530, Tirupathi Reddy wrote:
> Clkdiv module provides a clock output on the PMIC with CXO as
> the source. This clock can be routed through PMIC GPIOs. Add
> a device driver to configure this clkdiv module.
> 
> Signed-off-by: Tirupathi Reddy <tirupath@...eaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Normally your S-o-B would be last.

> ---
>  .../bindings/clock/clk-spmi-pmic-div.txt           |  59 ++++

Please split bindings to a separate patch.

Otherwise,

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/clk/qcom/Kconfig                           |   9 +
>  drivers/clk/qcom/Makefile                          |   1 +
>  drivers/clk/qcom/clk-spmi-pmic-div.c               | 308 +++++++++++++++++++++
>  4 files changed, 377 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/clk-spmi-pmic-div.txt
>  create mode 100644 drivers/clk/qcom/clk-spmi-pmic-div.c