[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171117202547.beetoal3wjaie6hp@dtor-ws>
Date: Fri, 17 Nov 2017 12:25:47 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Arvind Yadav <arvind.yadav.cs@...il.com>
Cc: maxime.ripard@...e-electrons.com, wens@...e.org,
linux@...ck-us.net, wsa@...-dreams.de, daniel.thompson@...aro.org,
mcuos.com@...il.com, linux-kernel@...r.kernel.org,
linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 02/10] Input: omap4-keypad: Fix platform_get_irq's error
checking
On Sat, Nov 18, 2017 at 12:45:24AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> drivers/input/keyboard/omap4-keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
> index 940d38b..8a4b161 100644
> --- a/drivers/input/keyboard/omap4-keypad.c
> +++ b/drivers/input/keyboard/omap4-keypad.c
> @@ -251,7 +251,7 @@ static int omap4_keypad_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (!irq) {
> + if (irq < 0) {
> dev_err(&pdev->dev, "no keyboard irq assigned\n");
> return -EINVAL;
return irq
> }
> --
> 2.7.4
>
--
Dmitry
Powered by blists - more mailing lists