linux-kernel - RE: [PATCH 2/2] drivers: visorbus: move driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR07MB31763A7DB17B0B2171B022FAF02F0@CY4PR07MB3176.namprd07.prod.outlook.com>
Date:   Fri, 17 Nov 2017 21:11:16 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jes.sorensen@...il.com" <jes.sorensen@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "driverdev-devel@...uxdriverproject.org" 
        <driverdev-devel@...uxdriverproject.org>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "erik.arfvidson@...il.com" <erik.arfvidson@...il.com>,
        "wadgaonkarsam@...il.com" <wadgaonkarsam@...il.com>
Subject: RE: [PATCH 2/2] drivers: visorbus: move driver out of staging

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@...radead.org]
> Sent: Friday, November 17, 2017 2:18 PM
> To: Kershner, David A <David.Kershner@...sys.com>
> Cc: gregkh@...uxfoundation.org; jes.sorensen@...il.com; linux-
> kernel@...r.kernel.org; driverdev-devel@...uxdriverproject.org; *S-Par-
> Maintainer <SParMaintainer@...sys.com>; erik.arfvidson@...il.com;
> wadgaonkarsam@...il.com
> Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging
> 
> Please don' tcreate new subdirectories under include/linux
> if you don't have to.
> 

Thanks for the feedback, the s-Par drivers have 3 include files in the
 include directory in drivers/staging/unisys/include. The patch currently
 moves 2 of them, and the third will be moved when the other drivers
 get out of staging. When I did the move, I thought one directory with
 three files would be cleaner than just adding three files to include. I
 will change that.

> Also who outside of unisys has reviewed this whole code?
> 

The driver has been in staging for 4 years with significant rework during
that period of time. Throughout that time, we have had input from several
different engineers, including Dan Carpenter, Jes Sorenson, and Greg KH.
In October, I requested a formal review from the community and after the
review had completed, Greg gave us the okay to move them out of staging.

> Instead of a move please send an actual patchset to add the new files
> so people can review it just like any other code.

Okay, I'll redo the patchset to show the explicit add of the files to
 the drivers directory.

Thanks,
David Kershner

Download attachment "smime.p7s" of type "application/pkcs7-signature" (7862 bytes)