linux-kernel - Re: [RFC patch 4/7] timekeeping: Add NMI safe accessor to mono/boot/real clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Nov 2017 00:43:30 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Prarit Bhargava <prarit@...hat.com>,
        Mark Salyzyn <salyzyn@...roid.com>,
        Petr Mladek <pmladek@...e.com>, Ingo Molnar <mingo@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: [RFC patch 4/7] timekeeping: Add NMI safe accessor to mono/boot/real
 clocks

On Fri, 17 Nov 2017, Linus Torvalds wrote:

> On Fri, Nov 17, 2017 at 3:00 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > Could you indent this better. It looks like timekeeping_delta_to_ns()
> > takes 4 arguments, when it really only takes two.
> 
> Actually, even better would be to simply not have that ugly three-line
> expression from hell.

I pondered and almost did that when I was hacking that up, but then
lazyness won :)