linux-kernel - Re: [PATCH 2/3 v2] Input: twl4030_keypad: Fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171118082047.GZ31757@n2100.armlinux.org.uk>
Date:   Sat, 18 Nov 2017 08:20:47 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     dmitry.torokhov@...il.com, maxime.ripard@...e-electrons.com,
        wens@...e.org, linux@...ck-us.net, wsa@...-dreams.de,
        daniel.thompson@...aro.org, mcuos.com@...il.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 2/3 v2] Input: twl4030_keypad: Fix platform_get_irq's
 error checking

On Sat, Nov 18, 2017 at 02:28:49AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.

IRQ 0 is not a valid interrupt.  The correct test here is <= 0.
Please rework your patches for this.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up