linux-kernel - Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hine78rbx.wl-tiwai@suse.de>
Date:   Sat, 18 Nov 2017 17:49:38 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     alsa-devel@...a-project.org, broonie@...nel.org,
        torvalds@...ux-foundation.org, vinod.koul@...el.com,
        liam.r.girdwood@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig

On Sat, 18 Nov 2017 01:01:56 +0100,
Pierre-Louis Bossart wrote:
> 
> +if SND_SOC_INTEL_BAYTRAIL
>  
>  config SND_SOC_INTEL_BYT_MAX98090_MACH
>  	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
> +	default n

default=n is superfluous, can be dropped.

>  	depends on X86_INTEL_LPSS && I2C
> -	depends on SND_SST_IPC_ACPI = n
> -	depends on SND_SOC_INTEL_BAYTRAIL
>  	select SND_SOC_MAX98090

So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I
guess this will allow this machine driver built although it shouldn't
be?


thanks,

Takashi