linux-kernel - Re: Commit fcd8843c40 breaks old compilers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cce6f1be-0481-4ecc-85e2-a626cf381ce3@oracle.com>
Date:   Sat, 18 Nov 2017 13:32:09 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Trond Myklebust <trondmy@...marydata.com>,
        "Anna.Schumaker@...app.com" <Anna.Schumaker@...app.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>
Subject: Re: Commit fcd8843c40 breaks old compilers



On 11/18/2017 01:12 PM, Trond Myklebust wrote:

> 
> Sigh.... OK, how about something like the following then:
> 
> { .data = { 0xff, 0xff, 0xff, 0xff, 0 }, }
> 


Yes, this does build.


diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 54fd56d..daa6085 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -71,8 +71,7 @@
  };
  const nfs4_stateid invalid_stateid = {
         {
-               .seqid = cpu_to_be32(0xffffffffU),
-               .other = { 0 },
+               .data = { 0xff, 0xff, 0xff, 0xff, 0 },
         },
         .type = NFS4_INVALID_STATEID_TYPE,
  };


-boris