linux-kernel - RE: [GIT PULL 2/3] ARM: SoC driver updates for 4.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 18 Nov 2017 02:03:49 +0000
From:   "Li, Philip" <philip.li@...el.com>
To:     "Wu, Fengguang" <fengguang.wu@...el.com>,
        Arnd Bergmann <arnd@...db.de>, "Hao, Shun" <shun.hao@...el.com>
CC:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        arm-soc <arm@...nel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms+renesas@...ge.net.au>
Subject: RE: [GIT PULL 2/3] ARM: SoC driver updates for 4.15

On Fri, Nov 17, 2017 at 7:50 AM, Fengguang Wu wrote:
> On Fri, Nov 17, 2017 at 12:25:12AM +0100, Arnd Bergmann wrote:
> >On Thu, Nov 16, 2017 at 11:29 PM, Linus Torvalds
> ><torvalds@...ux-foundation.org> wrote:
> >> On Thu, Nov 16, 2017 at 2:02 PM, Arnd Bergmann <arnd@...db.de> wrote:
> >>>
> >>> ARM: SoC driver updates for v4.15
> >>
> >> No. This is completely broken, and I can't imagine that it has ever
> >> compiled for *anybody*.
> >>
> >>   drivers/soc/renesas/r8a77970-sysc.c:14:10: fatal error:
> >> dt-bindings/power/r8a77970-sysc.h: No such file or directory
> >>    #include <dt-bindings/power/r8a77970-sysc.h>
> >>
> >> and the compiler is completely right. This branch added that
> >> r8a77970-sysc.c file, but never added the header file.
> >>
> >> And it's not some odd merge mistake of mine: I checked. That error is
> >> there in the original branch too.
> >>
> >> Tssk.
> >
> >Right, I need to figure out how this could have slipped through. I did
> >get several "BUILD SUCCESS" mails from the kbuild bot (see
> >https://pastebin.com/JDw3EKDZ), which claims to have built it
> >successfully in all configurations, including allmodconfig builds on
> >arm/arm64 and x86-64. Fengguang, do you remember problems
> >with false-negatives recently?
> 
> Sorry I checked log and didn't find any 0day reports for that error.
> 
> It actually hit the errors several times:
> 
> drivers/soc/renesas/r8a77970-sysc.c:14:11: sparse: unable to open 'dt-
> bindings/power/r8a77970-sysc.h'
> 
> 2017-10-21 07:23:12 on arm-soc/next/drivers
> 1c6788e8746d5250ad9bd16e1e48140a396f4733 x86_64-allmodconfig
> 
> 
> drivers/soc/renesas/r8a77970-sysc.c:14:45: fatal error: dt-
> bindings/power/r8a77970-sysc.h: No such file or directory
> 
> 2017-11-03 07:45:22 on arm-soc/next/drivers
> 30f3b0678ce6fc46bcdde61ca35821032d0f25b5 i386-allmodconfig
> 2017-11-03 08:42:45 on arm-soc/next/drivers
> 30f3b0678ce6fc46bcdde61ca35821032d0f25b5 arm-allmodconfig
> 2017-11-03 08:43:06 on arm-soc/next/drivers
> 30f3b0678ce6fc46bcdde61ca35821032d0f25b5 arm64-allmodconfig
> 
> So the robot is not working well in that case, I'll work with Philip
> to get that fixed.
Thanks Arnd/Fengguang. After the investigation from Shun, it shows the bisect
works as expected and can identify the bad commit. But this missing report
issue is because the build test server that runs the bisect happens to have
permission issue that prevents mutt to lock the "sent" file. 

This is more serious than expected since the issue has been there for quite long
time. I apologize for the misleading information provided that there's no error
reported out. We will monitor all the details carefully.

> 
> Regards,
> Fengguang