[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3a2f0905-231d-b2af-d1e8-1635158c6e53@users.sourceforge.net>
Date: Sun, 19 Nov 2017 07:37:37 +0100
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org
Cc: Julia Lawall <Julia.Lawall@...6.fr>,
Jaroslav Kysela <perex@...ex.cz>,
kernel-janitors@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: via82xx: Use common error handling code in
snd_via82xx_create()
>> @@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,
>>
>> *r_via = chip;
>> return 0;
>> +
>> +disable_device:
>> + pci_disable_device(pci);
>> + goto exit;
>> +free_chip:
>> + snd_via82xx_free(chip);
>> +exit:
>> + return err;
>
> Doubly goto doesn't look like an improvement.
Would you like to integrate another software update with the statement
“return err;” instead of “goto exit;” at this place?
Regards,
Markus
Powered by blists - more mailing lists