[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20171119211002.gddsvtxbuotyyznu@earth>
Date: Sun, 19 Nov 2017 22:10:02 +0100
From: Sebastian Reichel <sre@...nel.org>
To: Pavel Machek <pavel@....cz>
Cc: Ladislav Michl <ladis@...ux-mips.org>, pali.rohar@...il.com,
kernel list <linux-kernel@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
patrikbachan@...il.com, serge@...lyn.com, abcloriens@...il.com,
clayton@...ftyguy.net, martijn@...xit.nl,
sakari.ailus@...ux.intel.com, arnd@...db.de,
Filip Matijević <filip.matijevic.pz@...il.com>
Subject: Re: bh1770 hacks: get it to work on n950
Hi,
On Sun, Nov 19, 2017 at 04:07:30PM +0100, Pavel Machek wrote:
> On Sun 2017-11-19 15:12:13, Ladislav Michl wrote:
> > On Sun, Nov 19, 2017 at 01:41:50PM +0100, Pavel Machek wrote:
> > > On Fri 2017-11-17 12:35:40, Sebastian Reichel wrote:
> > > > Hi,
> > > >
> > > > On Thu, Nov 16, 2017 at 12:57:03PM +0100, Pavel Machek wrote:
> > > > > Hi!
> > > > >
> > > > > Ok, not for application, but I can get light sensor to work.
> > > > >
> > > > > Signed-off-by: Pavel Machek <pavel@....cz>
> > > >
> > > > There is no mainline user of this driver and it has a custom API, so
> > > > I think the driver should be dropped and an IIO based one should be
> > > > created instead.
> > >
> > > While I agree IIO interface might be better, and would welcome
> > > patches, I don't think that dropping the driver is right action at
> > > this point.
> >
> > That's the most elegant solution at all. How would you later motivate
> > people to try and test IIO driver? Let's pretend this patch have never
> > existed until someone notices and starts playing "you broke kernel ABI"
> > game.
>
> I'm using the driver; I'm even interested in fixing it. Please try not
> to make my job any harder than it needs to be, and I'll try to break
> ABI.
>
> That goes to Sebastian, too.
>
> If you want to convert the driver to IIO, please do so, I can test
> the patches.
Looks like I need to be more explicit, so be it:
NAKed-by: Sebastian Reichel <sre@...nel.org>
-- Sebastian
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists