linux-kernel - [PATCH] extract-cert: detect and warn if libssl is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20171120025531.10413-1-jc@linux.com>
Date:   Sun, 19 Nov 2017 18:55:29 -0800
From:   Jesse Chan <jc@...ux.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Jesse Chan <jc@...ux.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] extract-cert: detect and warn if libssl is missing

With CONFIG_SYSTEM_TRUSTED_KEYRING enabled, if the host system doesn't have
a development version of libssl installed, the build fails with
errors like:

  extract-cert.c: fatal error: openssl/bio.h: No such file or directory

In this case, prompt to install libssl-dev(el).

Signed-off-by: Jesse Chan <jc@...ux.com>
---
 scripts/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/scripts/Makefile b/scripts/Makefile
index 25ab143cbe14..6c75a32aae12 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -35,6 +35,14 @@ PHONY += build_unifdef
 build_unifdef: $(obj)/unifdef
 	@:
 
+ifdef CONFIG_SYSTEM_TRUSTED_KEYRING
+  has_libssl := $(call try-run,\
+		echo "int main() {}" | $(HOSTCC) -xc -o /dev/null -lssl -,1,0)
+  ifneq ($(has_libssl),1)
+    $(error "Cannot use CONFIG_SYSTEM_TRUSTED_KEYRING=y, please install libssl-dev or libssl-devel")
+  endif
+endif
+
 subdir-$(CONFIG_MODVERSIONS) += genksyms
 subdir-y                     += mod
 subdir-$(CONFIG_SECURITY_SELINUX) += selinux
-- 
2.14.1