linux-kernel - Re: [patch V2 02/11] LICENSES: Add the GPL 2.0 license

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Nov 2017 10:42:41 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Charlemagne Lasse <charlemagnelasse@...il.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        Andrew Morton <akpm@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christoph Hellwig <hch@....de>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Rob Herring <rob.herring@...aro.org>,
        Jonas Oberg <jonas@...e.org>, Joe Perches <joe@...ches.com>,
        linux-xfs@...r.kernel.org,
        Carmen Bianca Bakker <carmenbianca@...e.org>
Subject: Re: [patch V2 02/11] LICENSES: Add the GPL 2.0 license

On Sat, 18 Nov 2017, Charlemagne Lasse wrote:
> 2017-11-16 19:33 GMT+01:00 Thomas Gleixner <tglx@...utronix.de>:
> > Add the full text of the GPL 2.0 license to the kernel tree.  It was
> > copied directly from:
> >
> >    https://spdx.org/licenses/GPL-2.0.html#licenseText
> >
> > Add the required tags for reference and tooling.
> >
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> NACKed-by: Charlemagne Lasse <charlemagnelasse@...il.com>
> 
> This is neither the GPL-2.0 from https://www.gnu.org/licenses/gpl-2.0.txt
> (which you should have used) or
> https://spdx.org/licenses/GPL-2.0.html#licenseText
> 
> Please download the correct ASCII version from gnu.org and add your SPDX
> info in front of it. But I have also added detailed info about
> non-whitespace changes in your patch.

Indeed. I messed that up when I noticed that the license from the SPDX site
is indeed different from the COPYING file in a few minor aspects.

I started to rumage around to find out why and found the matching one on

  https://opensource.org/licenses/GPL-2.0

which is linked to from the SPDX page. I downloaded that version to check
the differences. The opensource page has the original version of the GPLv2
and not the one which got modified by FSF later on without changing the
version number.

I then decided to copy the text from COPYING, which is the right thing to
do as Jonas pointed, got dragged into dealing with a regression and forgot
about it. Neither did I update the changelog.

Thanks for spotting it!

I'll send out a revised version later.

Thanks,

	tglx