linux-kernel - Re: [PATCH] staging: comedi: ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e908b5b4-c1d0-c884-f67e-4fef35af6afa@mev.co.uk>
Date:   Mon, 20 Nov 2017 10:44:06 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Matthew Giassa <matthew@...ssa.net>, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: comedi: ni_atmio: fix license warning.

On 18/11/17 16:26, Matthew Giassa wrote:
> Resolving license check warning for drivers/staging/comedi. Added the
> license definitions present in the rest of the module and made sure it's
> aligned with the license (GPL) in the comments for the affected file
> (ni_atmio.c). Original warning:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi//drivers/ni_atmio.o
> see include/linux/module.h for more information.
> 
> No longer present after change.
> 
> Signed-off-by: Matthew Giassa <matthew@...ssa.net>
> ---
>   drivers/staging/comedi/drivers/ni_atmio.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 2d62a8c..ae6ed96 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -361,3 +361,8 @@ static struct comedi_driver ni_atmio_driver = {
>   	.detach		= ni_atmio_detach,
>   };
>   module_comedi_driver(ni_atmio_driver);
> +
> +MODULE_AUTHOR("Comedi http://www.comedi.org");
> +MODULE_DESCRIPTION("Comedi low-level driver");
> +MODULE_LICENSE("GPL");
> +
> 

Thanks.  I already reviewed a similar patch for the same driver by Jesse 
Chan, but that one never had the MODULE_AUTHOR line.  Also, your patch 
arrived earlier, so should take precedence.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-