linux-kernel - Re: [PATCH] sched/fair: Consider RT/IRQ pressure in capacity_spare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <980fc318-50b4-0494-6d20-b76c39ce86f3@arm.com>
Date:   Mon, 20 Nov 2017 11:43:09 +0000
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Joel Fernandes <joelaf@...gle.com>, linux-kernel@...r.kernel.org
Cc:     Vincent Guittot <vincent.guittot@...aro.org>,
        Morten Ramussen <morten.rasmussen@....com>,
        Brendan Jackman <brendan.jackman@....com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...il.com>,
        Patrick Bellasi <patrick.bellasi@....com>,
        Chris Redpath <Chris.Redpath@....com>,
        Steve Muckle <smuckle@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Saravana Kannan <skannan@...cinc.com>,
        Vikram Mulukutla <vmulukut@...cinc.com>,
        Rohit Jain <rohit.k.jain@...cle.com>,
        Atish Patra <atish.patra@...cle.com>,
        EAS Dev <eas-dev@...ts.linaro.org>,
        Android Kernel <kernel-team@...roid.com>
Subject: Re: [PATCH] sched/fair: Consider RT/IRQ pressure in
 capacity_spare_wake

On 11/09/2017 06:52 PM, Joel Fernandes wrote:

[...]

> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 56f343b8e749..ba9609407cb9 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5724,7 +5724,7 @@ static int cpu_util_wake(int cpu, struct task_struct *p);
>   
>   static unsigned long capacity_spare_wake(int cpu, struct task_struct *p)
>   {
> -	return capacity_orig_of(cpu) - cpu_util_wake(cpu, p);
> +	return max_t(long, capacity_of(cpu) - cpu_util_wake(cpu, p), 0);
>   }
>   
>   /*
> 

Looks good to me. Maybe you could mention in the patch header that you 
switch capacity_orig_of() for capacity_of() since its only a tiny diff 
in the hunk.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com>