linux-kernel - Re: [PATCH v1 0/9] perf stat: Enable '--per-thread' on all threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171120122952.GA12500@krava>
Date:   Mon, 20 Nov 2017 13:29:52 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 0/9] perf stat: Enable '--per-thread' on all threads

On Mon, Nov 20, 2017 at 08:15:56PM +0800, Jin, Yao wrote:
> 
> 
> On 11/20/2017 5:26 PM, Jiri Olsa wrote:
> > On Mon, Nov 20, 2017 at 10:43:35PM +0800, Jin Yao wrote:
> > > perf stat --per-thread is useful to break down data per thread.
> > > But it currently requires specifying --pid/--tid to limit it to a process.
> > > 
> > > For analysis it would be useful to do it globally for the whole system.
> > 
> > I can't compile this:
> > 
> > builtin-script.c: In function ‘perf_sample__fprint_metric’:
> > builtin-script.c:1549:2: error: too few arguments to function ‘perf_stat__update_shadow_stats’
> >    perf_stat__update_shadow_stats(evsel,
> >    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > In file included from builtin-script.c:24:0:
> > util/stat.h:134:6: note: declared here
> >   void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 count,
> >        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > builtin-script.c:1555:4: error: too few arguments to function ‘perf_stat__print_shadow_stats’
> >      perf_stat__print_shadow_stats(ev2,
> >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > In file included from builtin-script.c:24:0:
> > util/stat.h:143:6: note: declared here
> >   void perf_stat__print_shadow_stats(struct perf_evsel *evsel,
> >        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > mv: cannot stat './.builtin-script.o.tmp': No such file or directory
> > 
> > thanks,
> > jirka
> > 
> 
> Hi Jiri,
> 
> This patch set is based on the latest perf/core branch.
> 
> I pull the branch right now and try the build again, the building is OK.
> 
> Could you tell me which branch you are testing on?

ugh.. I was over Andi's changes.. I'll recheck

sry for noise

jirka