linux-kernel - Re: [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171120154655.GA13495@krava>
Date:   Mon, 20 Nov 2017 16:46:55 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        David Ahern <dsahern@...il.com>,
        Kan Liang <kan.liang@...el.com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf stat: Fix duplicate error messages in
 perf_stat_synthesize_config()

On Mon, Nov 20, 2017 at 04:30:13PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 20 Nov 2017 15:55:25 +0100
> 
> Duplicate error messages were used so far in this function implementation.
> Make them unique instead.
> 
> This issue was detected by using the Coccinelle software.
> 
> Fixes: 7b60a7e3a687481553d2b6ec7e6390a6e82f1849 ("perf stat record: Synthesize event update events")
> Fixes: 8b99b1a4e0b082ea6a277766982dac84483d4d3c ("perf stat record: Synthesize stat record data")
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> ---
>  tools/perf/builtin-stat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 59af5a8419e2..ed0f23bb2230 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -512,7 +512,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
>  		if (counter->own_cpus) {
>  			err = perf_event__synthesize_event_update_cpus(NULL, counter, process_synthesized_event);
>  			if (err < 0) {
> -				pr_err("Couldn't synthesize evsel scale.\n");
> +				pr_err("Couldn't synthesize evsel CPUs.\n");
>  				return err;
>  			}
>  		}
> @@ -541,7 +541,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
>  	err = perf_event__synthesize_cpu_map(NULL, evsel_list->cpus,
>  					     process_synthesized_event, NULL);
>  	if (err < 0) {
> -		pr_err("Couldn't synthesize thread map.\n");
> +		pr_err("Couldn't synthesize CPU map.\n");
>  		return err;
>  	}
>  
> -- 
> 2.15.0
>