linux-kernel - RE: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace interface if missing hotfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f2192b6a6ed4764b5645efa7f6f2a54@ausx13mpc120.AMER.DELL.COM>
Date:   Mon, 20 Nov 2017 16:03:53 +0000
From:   <Mario.Limonciello@...l.com>
To:     <dvhart@...radead.org>
CC:     <andy.shevchenko@...il.com>, <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>
Subject: RE: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace
 interface if missing hotfix

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@...radead.org]
> Sent: Friday, November 17, 2017 2:39 PM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>; LKML <linux-
> kernel@...r.kernel.org>; platform-driver-x86@...r.kernel.org
> Subject: Re: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace
> interface if missing hotfix
> 
> On Thu, Nov 16, 2017 at 10:13:12PM -0600, Mario Limonciello wrote:
> > The Dell SMBIOS WMI interface will fail for some more complex calls unless
> > a WMI hotfix has been included.  Most platforms have this fix available in
> > a maintenance BIOS release.  In the case the driver is loaded on a
> > platform without this fix, disable the userspace interface.
> >
> > A hotfix indicator is present in the dell-wmi-descriptor that represents
> > whether or not more complex calls will work properly.
> >
> > "Simple" calls such as those used by dell-laptop and dell-wmi will continue
> > to work properly so dell-smbios-wmi should not be blocked from binding and
> > being used as the dell-smbios dispatcher.
> >
> > Suggested-by: Girish Prakash <girish.prakash@...l.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>
> 
> Queued up, thanks Mario.

Darren, even though this came after the merge windows opened considering this 
restricts the SMBIOS interface from some platform/firmware combinations it 
shouldn't be offered, do you think this can be included with a future 4.15 
RCx PR so it can land with the rest of the series rather than targeted for 4.16?

I'd hate to get stuck in a situation that an interface deemed "broken" gets offered
to people it shouldn't.