linux-kernel - Re: [PATCH 17/30] x86, kaiser: map debug IDT tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711202139240.2348@nanos>
Date:   Mon, 20 Nov 2017 21:40:06 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        moritz.lipp@...k.tugraz.at, daniel.gruss@...k.tugraz.at,
        michael.schwarz@...k.tugraz.at, richard.fellner@...dent.tugraz.at,
        luto@...nel.org, torvalds@...ux-foundation.org,
        keescook@...gle.com, hughd@...gle.com, x86@...nel.org
Subject: Re: [PATCH 17/30] x86, kaiser: map debug IDT tables

On Fri, 10 Nov 2017, Dave Hansen wrote:
>  
> +static int kaiser_user_map_ptr_early(const void *start_addr, unsigned long size,
> +				 unsigned long flags)
> +{
> +	int ret = kaiser_add_user_map(start_addr, size, flags);
> +	WARN_ON(ret);
> +	return ret;

What's the point of the return value when it is ignored at the call site?

> +}
> +
>  /*
>   * Ensure that the top level of the (shadow) page tables are
>   * entirely populated.  This ensures that all processes that get
> @@ -374,6 +382,10 @@ void __init kaiser_init(void)
>  				  sizeof(gate_desc) * NR_VECTORS,
>  				  __PAGE_KERNEL_RO | _PAGE_GLOBAL);
>  
> +	kaiser_user_map_ptr_early(&debug_idt_table,
> +				  sizeof(gate_desc) * NR_VECTORS,
> +				  __PAGE_KERNEL | _PAGE_GLOBAL);
> +

Thanks,

	tglx