[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 20 Nov 2017 16:32:40 -0800
From: Nicolin Chen <nicoleotsuka@...il.com>
To: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc: Timur Tabi <timur@...i.org>, Xiubo Li <Xiubo.Lee@...il.com>,
alsa-devel@...a-project.org,
linux-kernel <linux-kernel@...r.kernel.org>,
Takashi Iwai <tiwai@...e.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Fabio Estevam <fabio.estevam@....com>,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: fsl_ssi: AC'97 ops need regmap,
clock and cleaning up on failure
On Mon, Nov 20, 2017 at 11:14:55PM +0100, Maciej S. Szmigiero wrote:
> AC'97 ops (register read / write) need SSI regmap and clock, so they have
> to be set after them.
>
> We also need to set these ops back to NULL if we fail the probe.
>
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
Acked-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
> sound/soc/fsl/fsl_ssi.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index dad80b4b0cfc..a71bb8391f61 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -1460,12 +1460,6 @@ static int fsl_ssi_probe(struct platform_device *pdev)
> sizeof(fsl_ssi_ac97_dai));
>
> fsl_ac97_data = ssi_private;
By the way, is there any better way to register the ops for AC97
while we could pass the ssi_private so as to remove the global
fsl_ac97_data?
Powered by blists - more mailing lists