linux-kernel - Re: [PATCH] [media] c8sectpfe: Use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d30b010-96b1-cf98-d98f-8c804631fb80@st.com>
Date:   Tue, 21 Nov 2017 08:47:21 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Vasyl Gomonovych <gomonovych@...il.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [media] c8sectpfe: Use resource_size function on memory
 resource

Hi Vasyl

On 11/20/2017 11:46 PM, Vasyl Gomonovych wrote:
> To adapt fei->sram_size calculation via resource_size for memory size
> calculation before, in fei->sram = devm_ioremap_resource(dev, res).
> And make memory initialization range in
> memset_io for fei->sram appropriate
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
>   drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 59280ac31937..283f7289aaa1 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -691,7 +691,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
>   	if (IS_ERR(fei->sram))
>   		return PTR_ERR(fei->sram);
>   
> -	fei->sram_size = res->end - res->start;
> +	fei->sram_size = resource_size(res);
>   
>   	fei->idle_irq = platform_get_irq_byname(pdev, "c8sectpfe-idle-irq");
>   	if (fei->idle_irq < 0) {
> 

Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks