linux-kernel - Re: [PATCH] drm/sti: Handle return value of platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+M3ks5Myyp+7kWwC1bW5-J7=A0nMnY8bq30-HYaL4jb5rQ5MQ@mail.gmail.com>
Date:   Tue, 21 Nov 2017 10:14:12 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/sti: Handle return value of platform_get_irq_byname

2017-11-17 11:36 GMT+01:00 Arvind Yadav <arvind.yadav.cs@...il.com>:
> platform_get_irq_byname() can fail here and we must check its return
> value.
>

Applied on drm-misc-next.

Thanks,
Benjamin

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/gpu/drm/sti/sti_hdmi.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index 30f02d2..adabd41 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1414,6 +1414,11 @@ static int sti_hdmi_probe(struct platform_device *pdev)
>         init_waitqueue_head(&hdmi->wait_event);
>
>         hdmi->irq = platform_get_irq_byname(pdev, "irq");
> +       if (hdmi->irq < 0) {
> +               DRM_ERROR("Cannot get HDMI irq\n");
> +               ret = hdmi->irq;
> +               goto release_adapter;
> +       }
>
>         ret = devm_request_threaded_irq(dev, hdmi->irq, hdmi_irq,
>                         hdmi_irq_thread, IRQF_ONESHOT, dev_name(dev), hdmi);
> --
> 2.7.4
>