linux-kernel - Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171121151814.GK20440@krava>
Date:   Tue, 21 Nov 2017 16:18:14 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation

On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote:

SNIP

> -	if ((stat_config.aggr_mode == AGGR_THREAD) && !target__has_task(&target)) {
> -		fprintf(stderr, "The --per-thread option is only available "
> -			"when monitoring via -p -t options.\n");
> -		parse_options_usage(NULL, stat_options, "p", 1);
> -		parse_options_usage(NULL, stat_options, "t", 1);
> -		goto out;
> +	if ((stat_config.aggr_mode == AGGR_THREAD) &&
> +		!target__has_task(&target)) {
> +		if (!target.system_wide || target.cpu_list) {
> +			fprintf(stderr, "The --per-thread option is only "
> +				"available when monitoring via -p -t "
> +				"options.\n");

the message should be updated with '-a' option, that you just added,
also why dont we support target.cpu_list, it should work no?

jirka