linux-kernel - Re: [PATCH] net: phy: harmonize phy_id{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9525d5e5-a26e-79b8-dfc3-8f7d73250fd6@gmail.com>
Date:   Tue, 21 Nov 2017 09:48:17 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Richard Leitner <dev@...l1n.net>, andrew@...n.ch
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        richard.leitner@...data.com
Subject: Re: [PATCH] net: phy: harmonize phy_id{,_mask} data type

On 11/21/2017 01:52 AM, Richard Leitner wrote:
> From: Richard Leitner <richard.leitner@...data.com>
> 
> Previously phy_id was u32 and phy_id_mask was unsigned int. As the
> phy_id_mask defines the important bits of the phy_id (and is therefore
> the same size) these two variables should be the same data type.
> 
> Signed-off-by: Richard Leitner <richard.leitner@...data.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!

> ---
> This patch is extracted from the "net: ethernet: fec: fix refclk enable for SMSC LAN8710/20"
> patch series. This was done because this series will be reworked and
> rebased on not yet merged feature later on. For more details see:
> https://patchwork.ozlabs.org/cover/839468/
> ---
>  include/linux/phy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index dc82a07cb4fd..e00fd9ce3bce 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -509,7 +509,7 @@ struct phy_driver {
>  	struct mdio_driver_common mdiodrv;
>  	u32 phy_id;
>  	char *name;
> -	unsigned int phy_id_mask;
> +	u32 phy_id_mask;
>  	u32 features;
>  	u32 flags;
>  	const void *driver_data;
> 


-- 
Florian