linux-kernel - Re: [PATCH v3 04/12] dt-bindings: fsi: Add P9 OCC hwmon device documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171121183605.eialwrmbu2hzcaix@rob-hp-laptop>
Date:   Tue, 21 Nov 2017 12:36:05 -0600
From:   Rob Herring <robh@...nel.org>
To:     Eddie James <eajames@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        linux@...ck-us.net, jdelvare@...e.com, corbet@....net,
        mark.rutland@....com, joel@....id.au,
        "Edward A. James" <eajames@...ibm.com>
Subject: Re: [PATCH v3 04/12] dt-bindings: fsi: Add P9 OCC hwmon device
 documentation

On Mon, Nov 20, 2017 at 05:53:33PM -0600, Eddie James wrote:
> From: "Edward A. James" <eajames@...ibm.com>
> 
> Document the bindings for the FSI-based OCC hwmon device.
> 
> Signed-off-by: Edward A. James <eajames@...ibm.com>
> ---
>  .../devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt
> 
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt
> new file mode 100644
> index 0000000..086b1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt
> @@ -0,0 +1,16 @@
> +Device-tree bindings for FSI-based On-Chip Controller hwmon device
> +------------------------------------------------------------------
> +
> +Required properties:
> + - compatible = "ibm,p9-occ-hwmon";
> +
> +Examples:
> +
> +    occ@1 {
> +        compatible = "ibm,p9-occ";
> +        reg = <1>;
> +
> +        occ-hwmon@1 {

Missing reg property or need to drop the unit-address.

> +            compatible = "ibm,p9-occ-hmwon";
> +        }

Missing ;

> +    };
> -- 
> 1.8.3.1
>