linux-kernel - Re: [PATCH] HID: cp2112: Fix I2C_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171121184012.GA6776@mail.arista.com>
Date:   Tue, 21 Nov 2017 10:40:12 -0800
From:   Eudean Sun <eudean@...sta.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions

On Tue, Nov 21, 2017 at 05:45:32PM +0100, Jiri Kosina wrote:
> On Tue, 21 Nov 2017, Jiri Kosina wrote:
> 
> > > The existing driver erroneously treats I2C_BLOCK_DATA and BLOCK_DATA
> > > commands the same. Fix the logic for I2C_BLOCK_DATA reads and writes.
> > 
> > Addin David, the original author of the driver (and the code in question 
> > as well) to CC.
> 
> Alright, that address bounces.
> 
> In that case -- could you please be a little bit more specific in the 
> changelog? Namely: what are the observable effects of this bug (did you 
> find it by code inspection or have you seen it triggering) and why this is 
> a proper fix for that bug.

Thanks for the feedback Jiri, I will send out a new patch shortly with more detail in the changelog.