linux-kernel - Re: [PATCH] selftest: sync: Use common error handling code in sync_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29abb1d8-95dd-fdf3-cecb-40d6c035508c@users.sourceforge.net>
Date:   Tue, 21 Nov 2017 19:55:25 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     shuah@...nel.org, linux-kselftest@...r.kernel.org,
        Emilio López <emilio.lopez@...labora.co.uk>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftest: sync: Use common error handling code in
 sync_file_info()

>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>>
>> This issue was detected by using the Coccinelle software.
> 
> I would like to see the Coccinelle log included in the commit log

I guess that I can not append the kind of report you might be looking for
so far. This small update suggestion is just another result from one
of my evolving scripts for the semantic patch language.

It was discussed under the topic “Comparing statement lists with SmPL”
to some degree.
https://systeme.lip6.fr/pipermail/cocci/2017-August/004388.html


>> @@ -104,22 +102,23 @@ static struct sync_file_info *sync_file_info(int fd)
>>  		info->num_fences = num_fences;
>>  
>>  		fence_info = calloc(num_fences, sizeof(*fence_info));
>> -		if (!fence_info) {
>> -			free(info);
>> -			return NULL;
>> -		}
>> +		if (!fence_info)
>> +			goto free_info;
>>  
>>  		info->sync_fence_info = (uint64_t)fence_info;
>>  
>>  		err = ioctl(fd, SYNC_IOC_FILE_INFO, info);
>>  		if (err < 0) {
>>  			free(fence_info);
> 
> Why not add a free_fence_info to make it consistent?

It did not add another jump label because it would be used only once
for this if branch (according to your enquiry).


>> -			free(info);
>> -			return NULL;
>> +			goto free_info;

Do you expect a second update approach for this source code place?

Regards,
Markus