linux-kernel - Re: kernel_read() changed from v4.13 to v4.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUO5V5S_Fmd5Zpc9eXytv+gdbfQTHZmxicXK=50fpT-XA@mail.gmail.com>
Date:   Tue, 21 Nov 2017 13:20:28 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     "Zytaruk, Kelly" <Kelly.Zytaruk@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: kernel_read() changed from v4.13 to v4.14

On Tue, Nov 21, 2017 at 1:05 PM, Zytaruk, Kelly <Kelly.Zytaruk@....com> wrote:
> I noticed that the parameter ordering to kernel_read() changed from Linux kernel v4.13 to v4.14 when the function was moved into fs/read_write.c from exec.c
>
> 4.13.15 - int kernel_read(struct file *file, loff_t offset, char *addr, unsigned long count)
>
> 4.14.1 - ssize_t kernel_read(struct file *file, void *buf, size_t count, loff_t *pos)
>
> I am still on the learning curve so I would like to understand why this was done instead of keeping the same ordering.


My guess is that it matches the syscall read() more closely.