linux-kernel - Re: [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 23:31:02 +0100
From:   Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>,
        Lukas Wunner <lukas@...ner.de>, linux-serial@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Subject: Re: [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0

ping?


On Mon, Nov 6, 2017 at 11:49 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@...il.com> wrote:
> According to the datasheet, only the first port supports delay before
> send and delay after send.
>
> Reported-by: "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>  drivers/tty/serial/8250/8250_fintek.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index ca7e96f9f080..61745d4bea31 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -216,6 +216,12 @@ static int fintek_8250_rs485_config(struct uart_port *port,
>         rs485->flags &= SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
>                         SER_RS485_RTS_AFTER_SEND;
>
> +       /* Only the first port supports delays */
> +       if (pdata->index) {
> +               rs485->delay_rts_before_send = 0;
> +               rs485->delay_rts_after_send = 0;
> +       }
> +
>         if (rs485->delay_rts_before_send) {
>                 rs485->delay_rts_before_send = 1;
>                 config |= TXW4C_IRA;
> --
> 2.14.2
>



-- 
Ricardo Ribalda