linux-kernel - RE: [PATCH v2] arm64: dts: ls1088a: Add USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <VI1PR04MB1262DD3C6A18257DEE2E907DE9200@VI1PR04MB1262.eurprd04.prod.outlook.com>
Date:   Wed, 22 Nov 2017 01:32:22 +0000
From:   Yinbo Zhu <yinbo.zhu@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "Catalin Marinas )" <catalin.marinas@....com>,
        "Will Deacon )" <will.deacon@....com>,
        Harninder Rai <harninder.rai@....com>,
        Raghav Dogra <raghav.dogra@....com>,
        Ashish Kumar <ashish.kumar@....com>,
        Andy Tang <andy.tang@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support

Hi

-----Original Message-----
From: Yinbo Zhu 
Sent: Tuesday, November 14, 2017 4:00 PM
To: 'Shawn Guo' <shawnguo@...nel.org>
Cc: 'Rob Herring' <robh+dt@...nel.org>; 'Mark Rutland' <mark.rutland@....com>; 'Catalin Marinas )' <catalin.marinas@....com>; 'Will Deacon )' <will.deacon@....com>; Harninder Rai <harninder.rai@....com>; 'Raghav Dogra' <raghav.dogra@....com>; Ashish Kumar <ashish.kumar@....com>; Andy Tang <andy.tang@....com>; 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS' <devicetree@...r.kernel.org>; 'linux-arm-kernel@...ts.infradead.org' <linux-arm-kernel@...ts.infradead.org>; 'open list' <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support



-----Original Message-----
From: Yinbo Zhu 
Sent: Tuesday, October 24, 2017 5:15 PM
To: Shawn Guo <shawnguo@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Catalin Marinas ) <catalin.marinas@....com>; Will Deacon ) <will.deacon@....com>; Harninder Rai <harninder.rai@....com>; Raghav Dogra <raghav.dogra@....com>; Ashish Kumar <ashish.kumar@....com>; Andy Tang <andy.tang@....com>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org; open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support


-----Original Message-----
From: Shawn Guo [mailto:shawnguo@...nel.org] 
Sent: Friday, September 22, 2017 2:55 PM
To: Yinbo Zhu <yinbo.zhu@....com>
Cc: Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Catalin Marinas ) <catalin.marinas@....com>; Will Deacon ) <will.deacon@....com>; Harninder Rai <harninder.rai@....com>; Raghav Dogra <raghav.dogra@....com>; Ashish Kumar <ashish.kumar@....com>; Andy Tang <andy.tang@....com>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org; open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ls1088a: Add USB support

On Wed, Sep 13, 2017 at 05:10:09PM +0800, yinbo.zhu@....com wrote:
> From: "yinbo.zhu" <yinbo.zhu@....com>
> 
> Fix the issue that usb is not detected on ls1088ardb

>It's not really about fixing issue but adding support.

The patch had been tested on upstream 4.14 code, it can fix the issue. 
> 
> Signed-off-by: yinbo.zhu <yinbo.zhu@....com>
> Signed-off-by: Ran Wang <ran.wang_1@....com>
> ---

>You should better have a version history here to tell what's changed between version.

>I will add a version history on next v3 patch
Hi,

I had modified the code as v4 version, 
https://patchwork.kernel.org/patch/10027393/
please check.

Thanks,
BRs
>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    | 20 ++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 213abb72de93..6c3c3bc4b681 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -118,6 +118,14 @@
>  	status = "okay";
>  };
>  
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
>  &esdhc {

>Please sort these labeled nodes alphabetically.

>Shawn

>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index c144d06a6e33..c23fede8cf5d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -359,6 +359,26 @@
>  			status = "disabled";
>  		};
>  
> +		usb0: usb3@...0000 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3100000 0x0 0x10000>;
> +			interrupts = <0 80 IRQ_TYPE_LEVEL_HIGH>;
> +			dr_mode = "host";
> +			snps,quirk-frame-length-adjustment = <0x20>;
> +			snps,dis_rxdet_inp3_quirk;
> +			status = "disabled";
> +		};
> +
> +		usb1: usb3@...0000 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3110000 0x0 0x10000>;
> +			interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> +			dr_mode = "host";
> +			snps,quirk-frame-length-adjustment = <0x20>;
> +			snps,dis_rxdet_inp3_quirk;
> +			status = "disabled";
> +		};
> +
>  		sata: sata@...0000 {
>  			compatible = "fsl,ls1088a-ahci";
>  			reg = <0x0 0x3200000 0x0 0x10000>,
> --
> 2.14.1
>