linux-kernel - Re: 答复: [PATCH v5,1/2] misc: rtsx: Move Realtek Card Reader Driver to misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3sy+0m4aBOZJxJdehi3vFqgnCN9mtU=zsRrpmwqyoCzA@mail.gmail.com>
Date:   Wed, 22 Nov 2017 10:35:05 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     冯锐 <rui_feng@...lsil.com.cn>
Cc:     kbuild test robot <lkp@...el.com>,
        "kbuild-all@...org" <kbuild-all@...org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ricky_wu@...ltek.com" <ricky_wu@...ltek.com>
Subject: Re: 答复: [PATCH v5,1/2] misc: rtsx: Move Realtek Card Reader Driver to misc

On Wed, Nov 22, 2017 at 4:24 AM, 冯锐 <rui_feng@...lsil.com.cn> wrote:
> Dear all:
>
> I checked the file ".config", I found " CONFIG_MMC_REALTEK_USB=y " but its dependence MISC_RTSX_USB is not selected, so compile errors occurred.
> What should I do to fix it?

The problem is this bit in the Makefile:

--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -55,6 +55,7 @@ obj-$(CONFIG_CXL_BASE)                += cxl/
 obj-$(CONFIG_ASPEED_LPC_CTRL)  += aspeed-lpc-ctrl.o
 obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o
 obj-$(CONFIG_PCI_ENDPOINT_TEST)        += pci_endpoint_test.o
+obj-$(CONFIG_MISC_RTSX_PCI)    += cardreader/

 lkdtm-$(CONFIG_LKDTM)          += lkdtm_core.o
 lkdtm-$(CONFIG_LKDTM)          += lkdtm_bugs.o

I would suggest changing this to CONFIG_MISC_RTSX, and adding that symbol like

config MISC_RTSX
         tristate
         default MISC_RTSX_PCI || MISC_RTSX_USB

Then we enter the directory if one of the two gets selected.

You could also use "obj-y   += cardreader/" in the Makefile, but I
think the extra
symbol is a bit nicer, as it avoids entering the subdirectory when we
don't need it.

      Arnd