lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Nov 2017 14:02:58 +0200 From: Adrian Hunter <adrian.hunter@...el.com> To: Arvind Yadav <arvind.yadav.cs@...il.com>, ben-linux@...ff.org, ulf.hansson@...aro.org, vireshk@...nel.org, maxime.ripard@...e-electrons.com, wens@...e.org, linux@...linux.org.uk, carlo@...one.org, khilman@...libre.com Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org, linux-amlogic@...ts.infradead.org Subject: Re: [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq On 19/11/17 06:52, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com> Acked-by: Adrian Hunter <adrian.hunter@...el.com> > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. > changes in v3 : > return -EINVAL instead of host->irq. > > drivers/mmc/host/sdhci-acpi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index b988997..0d9965b 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev) > host->hw_name = "ACPI"; > host->ops = &sdhci_acpi_ops_dflt; > host->irq = platform_get_irq(pdev, 0); > + if (host->irq <= 0) { > + err = -EINVAL; > + goto err_free; > + } > > host->ioaddr = devm_ioremap_nocache(dev, iomem->start, > resource_size(iomem)); >
Powered by blists - more mailing lists