linux-kernel - Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1511366604.6989.93.camel@perches.com>
Date:   Wed, 22 Nov 2017 08:03:24 -0800
From:   Joe Perches <joe@...ches.com>
To:     Patryk Kocielnik <patryk.kocielnik@...il.com>,
        sudipm.mukherjee@...il.com
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

On Wed, 2017-11-22 at 16:42 +0100, Patryk Kocielnik wrote:
> Cleaned checkpatch warnings by fixing coding style issues.

checkpatch is not always correct.

> Signed-off-by: Patryk Kocielnik <patryk.kocielnik@...il.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
[]
> @@ -32,7 +32,7 @@
>  static int g_hwcursor = 1;
>  static int g_noaccel;
>  static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};

Make sure you compile any file modified by a patch
_before_ submitting the proposed patch.

>  static const char *g_def_fbmode = "1024x768-32@60";
>  static char *g_settings;
>  static int g_dualview;
> @@ -749,7 +749,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>  		lynx750_ext, NULL, vesa_modes,
>  	};
>  	int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
> -	static const char *mdb_desc[] = {
> +	static const char * const mdb_desc[] = {
>  		"driver prepared modes",
>  		"kernel prepared default modedb",
>  		"kernel HELPERS prepared vesa_modes",