lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Nov 2017 17:45:46 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Sinan Kaya <okaya@...eaurora.org> Cc: linux-pci@...r.kernel.org, timur@...eaurora.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Philippe Ombredanne <pombredanne@...b.com>, Kate Stewart <kstewart@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() On Wed, Nov 22, 2017 at 11:15:47AM -0500, Sinan Kaya wrote: > On 11/22/2017 2:53 AM, Greg Kroah-Hartman wrote: > >> +++ b/include/linux/i7300_idle.h > >> @@ -48,7 +48,7 @@ static inline int i7300_idle_platform_probe(struct pci_dev **fbd_dev, > >> int i; > >> struct pci_dev *memdev, *dmadev; > >> > >> - memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN); > >> + memdev = pci_get_domain_bus_and_slot(0, MEMCTL_BUS, MEMCTL_DEVFN); > > You have a pci_dev, why can't you use it here to get the domain? > > > > Both fbd_dev and ioat_dev are output parameters. > > dmadev = pci_get_bus_and_slot(IOAT_BUS, IOAT_DEVFN); > memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN); > > for (i = 0; fbd_ioat_list[i].vendor != 0; i++) { > if (dmadev->vendor == fbd_ioat_list[i].vendor && > dmadev->device == fbd_ioat_list[i].ioat_dev) { > if (!(fbd_ioat_list[i].enabled || enable_all)) > continue; > > if (fbd_dev) > *fbd_dev = memdev; > if (ioat_dev) > *ioat_dev = dmadev; > > Funny thing is nobody is calling this function. Maybe, I should just kill it > instead. Yes, delete it. Why doesn't the build warn about it not being used? thanks, greg k-h
Powered by blists - more mailing lists