linux-kernel - Re: [PATCH] drm/amd/display: fix memory leaks on error exit return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f0ece54-283a-aab6-da42-9102565e8e7e@amd.com>
Date:   Wed, 22 Nov 2017 12:13:35 -0500
From:   Harry Wentland <harry.wentland@....com>
To:     Colin King <colin.king@...onical.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Tony Cheng <tony.cheng@....com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: fix memory leaks on error exit return

On 2017-11-22 11:47 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently in the case where some of the allocations fail for dce110_tgv,
> dce110_xfmv, dce110_miv or dce110_oppv then the exit return path ends
> up leaking allocated objects. Fix this by kfree'ing them before returning.
> Also re-work the comparison of the null pointers to use the !ptr idiom.
> 
> Detected by CoverityScan, CID#1460246, 1460325, 1460324, 1460392
> ("Resource Leak")
> 
> Fixes: c4562236b3bc ("drm/amd/dc: Add dc display driver (v2)")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks. I got the same patch but was too slow to post.

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index db96d2b47ff1..61adb8174ce0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -1037,11 +1037,13 @@ static bool underlay_create(struct dc_context *ctx, struct resource_pool *pool)
>  	struct dce110_opp *dce110_oppv = kzalloc(sizeof(*dce110_oppv),
>  						 GFP_KERNEL);
>  
> -	if ((dce110_tgv == NULL) ||
> -		(dce110_xfmv == NULL) ||
> -		(dce110_miv == NULL) ||
> -		(dce110_oppv == NULL))
> -			return false;
> +	if (!dce110_tgv || !dce110_xfmv || !dce110_miv || !dce110_oppv) {
> +		kfree(dce110_tgv);
> +		kfree(dce110_xfmv);
> +		kfree(dce110_miv);
> +		kfree(dce110_oppv);
> +		return false;
> +	}
>  
>  	dce110_opp_v_construct(dce110_oppv, ctx);
>  
>