linux-kernel - Re: [PATCH 4.4 00/59] 4.4.100-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171122174525.GB18549@flashbox>
Date:   Wed, 22 Nov 2017 10:45:25 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net,
        shuahkh@....samsung.com, patches@...nelci.org,
        ben.hutchings@...ethink.co.uk, stable@...r.kernel.org
Subject: Re: [PATCH 4.4 00/59] 4.4.100-stable review

On Wed, Nov 22, 2017 at 06:03:31PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 20, 2017 at 12:43:52PM -0700, Nathan Chancellor wrote:
> > On Mon, Nov 20, 2017 at 08:27:07PM +0100, Greg Kroah-Hartman wrote:
> > > On Sun, Nov 19, 2017 at 12:48:51PM -0700, Nathan Chancellor wrote:
> > > > On Sun, Nov 19, 2017 at 03:32:08PM +0100, Greg Kroah-Hartman wrote:
> > > > 
> > > > Merged, compiled, and flashed onto my Pixel 2 XL. No initial issues
> > > > noticed in either dmesg or general usage.
> > > 
> > > Wonderful, thanks for testing.
> > > 
> > > Just a side note, are you able to do 'fastboot kernelimage' with this
> > > device, or do you have to flash a whole new boot image in order to test
> > > out a new kernel?  If the later, any public scripts around to make this
> > > easy to do, I'm thinking I should get one of these to do the same sort
> > > of testing...
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > >
> > 
> > No, I wish fastboot flash kernel Image.gz-dtb was a thing on the Pixel 2
> > XL but Google omitted it unfortunately (they didn't on the Pixel 2
> > apparently which I find odd but whatever).
> 
> That seems really odd, as last I checked, it was the same build image
> for the kernel for both devices.  I know it's the same source tree, and
> .config file.
> 
> Does one perhaps use a kernel module for some hardware and the Pixel 2
> does not?  That would break the ability to use fastboot flash here.
> 

Yeah, it's the same source and config but I guess the internal
partitions are different (must be a byproduct of having different
manufacturers). Luckily, there should be no downside to using a boot
image because Google publicizes the device trees along with the proper
tags (just adds a minute or two compilation...)

Both devices do use kernel modules though, for the battery and the
touchscreen drivers. Initially, the amateur developers just brute
force loaded the kernel modules in check_version but that gives us
less control so I built the drivers into the kernel image (which is
not exactly ideal either according to Google's specs but it's not
like I have a ton of other options...)

> > All of my tools are publicly available, I'll link them below.
> > 
> > The build script handles compiling the kernel and boot image, the
> > manifest is to sync the bare essentials down so you don't have to pull
> > down a full AOSP tree, and the flashing function pulls the boot image
> > down off my server and flashes it to the device without manually doing
> > commands. I've also linked the kernel tree if you care to look through
> > anything.
> > 
> > Cheers!
> > Nathan
> > 
> > Script: https://github.com/nathanchance/scripts/blob/master/flash
> > Manifest: https://github.com/nathanchance/pixel2-manifest
> > Flashing: https://github.com/nathanchance/scripts/blob/master/os_darwin#L191
> > Kernel tree: https://github.com/nathanchance/wahoo
> 
> Wonderful, thanks for this, I'll try to play around with it.
> 
> greg k-h

Any improvements or comments are certainly welcome, glad I could be of
help.

Nathan