linux-kernel - Re: [bisected] system hang after boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171122202217.GO3326@worktop>
Date:   Wed, 22 Nov 2017 21:22:17 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Will Deacon <will.deacon@....com>
Cc:     Sebastian Ott <sebott@...ux.vnet.ibm.com>,
        Ingo Molnar <mingo@...nel.org>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [bisected] system hang after boot

On Wed, Nov 22, 2017 at 06:26:59PM +0000, Will Deacon wrote:

> Now, I can't see what the break_lock is doing here other than causing
> problems. Is there a good reason for it, or can you just try removing it
> altogether? Patch below.

The main use is spin_is_contended(), which in turn ends up used in
__cond_resched_lock() through spin_needbreak().

This allows better lock wait times for PREEMPT kernels on platforms
where the lock implementation itself cannot provide 'contended' state.

In that capacity the write-write race shouldn't be a problem though.

That said, I'd not be horribly sad to see this go, I've always found it
to be quite the ugly hack and taking it out should provide some
incentive for better lock implementations for the archs relying on this.