linux-kernel - Re: [PATCH 05/62] radix tree: Add a missing cast to gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171122222402.GA13634@bombadil.infradead.org>
Date:   Wed, 22 Nov 2017 14:24:02 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Matthew Wilcox <mawilcox@...rosoft.com>
Subject: Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t

On Wed, Nov 22, 2017 at 10:28:48PM +0100, Luc Van Oostenryck wrote:
> > -	root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1;
> > +	root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1);
> 
> IMO, it would be better to define something for that in radix-tree.h,
> like it has been done for ROOT_IS_IDR.

If we were keeping the radix tree around, I'd agree, but the point of
the rest of this patch set is replacing it ;-)  I should probably have
just dropped this patch, to be honest.