linux-kernel - RE: [PATCH AUTOSEL for 4.9 37/54] RDMA/qedr: Fix RDMA CM loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Nov 2017 06:11:32 +0000
From:   "Amrani, Ram" <Ram.Amrani@...ium.com>
To:     "alexander.levin@...izon.com" <alexander.levin@...izon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
CC:     "Elior, Ariel" <Ariel.Elior@...ium.com>,
        Doug Ledford <dledford@...hat.com>
Subject: RE: [PATCH AUTOSEL for 4.9 37/54] RDMA/qedr: Fix RDMA CM loopback

> From: Ram Amrani <Ram.Amrani@...ium.com>
> 
> [ Upstream commit af2b14b8b8ae21b0047a52c767ac8b44f435a280 ]
> 
> The loopback logic in RDMA CM packets compares Ethernet addresses and
> was accidently inverse.
> 
> Signed-off-by: Ram Amrani <Ram.Amrani@...ium.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@...ium.com>
> Signed-off-by: Doug Ledford <dledford@...hat.com>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
> ---
>  drivers/infiniband/hw/qedr/qedr_cm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw/qedr/qedr_cm.c
> index 63890ebb72bd..eccf7039aaca 100644
> --- a/drivers/infiniband/hw/qedr/qedr_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_cm.c
> @@ -404,9 +404,9 @@ static inline int qedr_gsi_build_packet(struct qedr_dev *dev,
>  	}
> 
>  	if (ether_addr_equal(udh.eth.smac_h, udh.eth.dmac_h))
> -		packet->tx_dest = QED_ROCE_LL2_TX_DEST_NW;
> -	else
>  		packet->tx_dest = QED_ROCE_LL2_TX_DEST_LB;
> +	else
> +		packet->tx_dest = QED_ROCE_LL2_TX_DEST_NW;
> 
>  	packet->roce_mode = roce_mode;
>  	memcpy(packet->header.vaddr, ud_header_buffer, header_size);
> --
> 2.11.0


Thanks!

Acked-by: Ram Amrani <Ram.Amrani@...ium.com>