linux-kernel - Re: [PATCH v7 02/13] dt-bindings: Add SLIMbus bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171123074115.5wvniuoiil4dplow@localhost.localdomain>
Date:   Thu, 23 Nov 2017 07:41:15 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Rob Herring <robh@...nel.org>
CC:     <srinivas.kandagatla@...aro.org>, <gregkh@...uxfoundation.org>,
        <broonie@...nel.org>, <alsa-devel@...a-project.org>,
        <sdharia@...eaurora.org>, <bp@...e.de>, <poeschel@...onage.de>,
        <treding@...dia.com>, <andreas.noever@...il.com>,
        <alan@...ux.intel.com>, <mathieu.poirier@...aro.org>,
        <daniel@...ll.ch>, <jkosina@...e.cz>,
        <sharon.dvir1@...l.huji.ac.il>, <joe@...ches.com>,
        <davem@...emloft.net>, <james.hogan@...tec.com>,
        <michael.opdenacker@...e-electrons.com>, <pawel.moll@....com>,
        <mark.rutland@....com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <vinod.koul@...el.com>, <arnd@...db.de>
Subject: Re: [PATCH v7 02/13] dt-bindings: Add SLIMbus bindings

On Wed, Nov 15, 2017 at 11:15:00PM -0600, Rob Herring wrote:
> On Wed, Nov 15, 2017 at 02:10:32PM +0000, srinivas.kandagatla@...aro.org wrote:
> > From: Sagar Dharia <sdharia@...eaurora.org>
> > 
> > SLIMbus (Serial Low Power Interchip Media Bus) is a specification
> > developed by MIPI (Mobile Industry Processor Interface) alliance.
> > SLIMbus is a 2-wire implementation, which is used to communicate with
> > peripheral components like audio-codec.
> > 
> > This patch adds device tree bindings for the slimbus.
> > 
> > Signed-off-by: Sagar Dharia <sdharia@...eaurora.org>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > ---
> >  Documentation/devicetree/bindings/slimbus/bus.txt | 50 +++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/slimbus/bus.txt
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

I still have some reservations about the putting the MID and PID
in the compatible sting, are we sure this is what we want to do?
As has been discussed previous the discoverability of SLIMbus
is really theoretical since you really always need to bind a
driver to power on the device, since power is not part of the bus
itself.

Many devices (ours included) will support SLIMbus and other
interfaces, this means we will need a different compatible
string between SLIMbus and I2C/SPI, which feels a little
icky.  Additionally it does make the compatible strings really
unreadable and which is a little annoying when looking at device
trees as you can't easily see what things are.

Thanks,
Charles