linux-kernel - Re: [Intel-gfx] [PATCH] drm/i915: Avoid enum conversion warning

Open Source and information security mailing list archives

Date:   Thu, 23 Nov 2017 08:59:46 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Nick Desaulniers <nick.desaulniers@...il.com>
Cc:     paulo.r.zanoni@...el.com, David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        mka@...omium.org, dri-devel@...ts.freedesktop.org,
        Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Avoid enum conversion warning

On Wed, Nov 22, 2017 at 11:50:48PM -0800, Nick Desaulniers wrote:
> Fixes the following enum conversion warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
> from enumeration type 'enum port' to different enumeration type 'enum
> intel_dpll_id' [-Werror,-Wenum-conversion]
>         enum intel_dpll_id pll_id = port;
>                            ~~~~~~   ^~~~
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@...il.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 933c18fd4258..f9de45316901 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1478,7 +1478,7 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
>  {
>  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>  	enum port port = intel_ddi_get_encoder_port(encoder);
> -	enum intel_dpll_id pll_id = port;
> +	uint32_t pll_id = port;

Please do a cast instead of dropping the dpll enum annotation. Just
shutting up compilers doesn't really help anyone.
-Daniel
>  
>  	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
>  
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives