linux-kernel - Re: [PATCH v3 RESEND] f2fs: add bug_on when f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77657045-2bba-2c31-f668-de6351c3f342@kernel.org>
Date:   Thu, 23 Nov 2017 21:05:12 +0800
From:   Chao Yu <chao@...nel.org>
To:     Yunlong Song <yunlong.song@...wei.com>, jaegeuk@...nel.org,
        yuchao0@...wei.com, yunlong.song@...oud.com
Cc:     miaoxie@...wei.com, bintian.wang@...wei.com,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 RESEND] f2fs: add bug_on when f2fs_gc even fails to get
 one victim

On 2017/11/22 11:50, Yunlong Song wrote:
> ping again...
> 
> On 2017/11/17 9:09, Yunlong Song wrote:
>> This can help to find potential bugs on some corner case.

Could you test this patch with fstest suit? if there are any testcases
can trigger this bug_on, it will be better to fix them all together.

Thanks,

>>
>> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
>> ---
>>   fs/f2fs/gc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>> index 5d5bba4..c89128b 100644
>> --- a/fs/f2fs/gc.c
>> +++ b/fs/f2fs/gc.c
>> @@ -1035,6 +1035,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>           goto stop;
>>       }
>>       if (!__get_victim(sbi, &segno, gc_type)) {
>> +        f2fs_bug_on(sbi, !total_freed && has_not_enough_free_secs(sbi, 0, 0));
>>           ret = -ENODATA;
>>           goto stop;
>>       }
>