linux-kernel - Re: [PATCH] kbuild: package: use --transform option to prefix paths in tar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQLt=ka0OffeD-2DkjKnb=JuGNgOGgeN5AatEXihH=4fA@mail.gmail.com>
Date:   Thu, 23 Nov 2017 23:19:14 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Sam Ravnborg <sam@...nborg.org>, Michal Marek <mmarek@...e.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: package: use --transform option to prefix paths
 in tar

2017-11-15 18:17 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> For rpm-pkg and deb-pkg, a source tar file is created.  All paths in
> the archive must be prefixed with the base name of the tar.  That
> means, everything is contained in the directory when you extract it.
>
> Currently, scripts/package/Makefile uses a symlink for that, and
> removes it after the tar is created.
>
> If you terminate the build during the tar creation, the symlink is
> left over.  Then, at the next package build, you will see a warning
> like follows:
>
>   ln: '.' and 'kernel-4.14.0+/.' are the same file
>
> It is possible to fix it by adding -n (--no-dereference) option to
> the "ln" command, but a cleaner way is to use --transform option
> of "tar" command.  This option is GNU extension, but it should not
> hurt to use it in the Linux build system.
>
> The 'S' flag is needed to exclude symlinks from the path fixup.
> Without it, symlinks in the kernel are broken.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---


Applied to linux-kbuild.


-- 
Best Regards
Masahiro Yamada