linux-kernel - Re: [PATCH 3.16 100/133] bcache: correct cache_dirty_target in __update_writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1511446910.2024.0.camel@perches.com>
Date:   Thu, 23 Nov 2017 06:21:50 -0800
From:   Joe Perches <joe@...ches.com>
To:     Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     akpm@...ux-foundation.org, Coly Li <colyli@...e.de>,
        Tang Junhui <tang.junhui@....com.cn>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 3.16 100/133] bcache: correct cache_dirty_target in
 __update_writeback_rate()

On Thu, 2017-11-23 at 13:08 +0000, Ben Hutchings wrote:
> On Tue, 2017-11-21 at 19:41 -0800, Joe Perches wrote:
> > On Wed, 2017-11-22 at 01:58 +0000, Ben Hutchings wrote:
> > > 3.16.51-rc1 review patch.  If anyone has any objections, please let me know.
> > []
> > > --- a/drivers/md/bcache/writeback.h
> > > +++ b/drivers/md/bcache/writeback.h
> > > @@ -14,6 +14,25 @@ static inline uint64_t bcache_dev_sector
> > >  	return ret;
> > >  }
> > >  
> > > +static inline uint64_t  bcache_flash_devs_sectors_dirty(struct cache_set *c)
> > > +{
> > > +	uint64_t i, ret = 0;
> > 
> > There's no reason i should be uint64_t
> > as nr_uuids is unsigned int.
> 
> But this still works, right?  That's a minor issue to deal with
> upstream, not in the backport.

correct