lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 23 Nov 2017 16:00:52 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.cz>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs: handle shrinker registration failure in sget_userns

On Thu 23-11-17 14:47:35, Al Viro wrote:
> On Thu, Nov 23, 2017 at 12:52:47PM +0100, Michal Hocko wrote:
> > @@ -503,12 +504,18 @@ struct super_block *sget_userns(struct file_system_type *type,
> >  		s = alloc_super(type, (flags & ~SB_SUBMOUNT), user_ns);
> >  		if (!s)
> >  			return ERR_PTR(-ENOMEM);
> > +		if (register_shrinker(&s->s_shrink)) {
> > +			spin_unlock(&sb_lock);
> > +			destroy_unused_super(s);
> > +			return ERR_PTR(-ENOMEM);
> 
> Have you even tested that?  What the hell is that spin_unlock() doing there?

Yeah, that patch was just screwed up. Have a look at
http://lkml.kernel.org/r/20171123143537.ztpxpk3sjbpo72rf@dhcp22.suse.cz
which should even resemble a real patch.

Sorry about all the confusion.

-- 
Michal Hocko
SUSE Labs

Powered by blists - more mailing lists