linux-kernel - Re: [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20977491-3a0a-1136-e35f-7b5c47dcfe18@savoirfairelinux.com>
Date:   Thu, 23 Nov 2017 11:28:52 -0500
From:   Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        kernel@...oirfairelinux.com,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>, kris@...eddedarm.com,
        Mark Featherston <mark@...eddedarm.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree

Hi Fabio,

On 11/22/2017 03:48 PM, Fabio Estevam wrote:
> On Wed, Nov 22, 2017 at 6:32 PM, Sebastien Bourdelin
> <sebastien.bourdelin@...oirfairelinux.com> wrote:
> 
>> +/dts-v1/;
>> +#include "imx6q.dtsi"
>> +#include "imx6qdl-ts7970.dtsi"
>> +
>> +/ {
>> +       model = "Technologic Systems i.MX6 Quad TS-7970 (Default Devuice Tree)";
> 
> Typo: Devuice--> Device
Thanks!
> 
>> +       reg_can1_3v3: reg_can1_3v3 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "reg_can1_3v3";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
> 
> Are you sure this is GPIO_ACTIVE_HIGH?
> 
> If so, then it would need the 'enable-active-high' property.
Ok
> 
> 
>> +       };
>> +
>> +       reg_can2_3v3: en-reg_can2_3v3 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "reg_can2_3v3";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio6 31 GPIO_ACTIVE_HIGH>;
> 
> Same here.
Ok
> 
>> +
>> +&fec {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_enet>;
>> +       interrupts-extended = <&gpio1 6 0x04>, <&gpc 0 119 0x04>;
> 
> I think you meant to say:
> 
> interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
>       <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> fsl,err006687-workaround-present;
Nice for the workaround, thanks!

> 
>> +&pcie {
>> +       reset-gpio = <&gpio2 21 GPIO_ACTIVE_HIGH>;
> 
> Are you sure it is GPIO_ACTIVE_HIGH? if so, it would need a
> reset-gpio-active-high property.
> 
> Most likely this should be:
> 
> reset-gpio = <&gpio2 21 GPIO_ACTIVE_LOW>;
> 
I have difficulties to verify this information, i will remove it unless
Mark Featherston can confirm it.

Thanks for your review Fabio!