linux-kernel - Re: [PATCH] xfs: handle register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171123163115.gmm7q6p5ut4pfp7n@dhcp22.suse.cz>
Date:   Thu, 23 Nov 2017 17:31:15 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:     hch@...radead.org, darrick.wong@...cle.com, david@...morbit.com,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: handle register_shrinker error

On Fri 24-11-17 01:17:12, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > Hmm, you are right. I have (blindly) followed the current code flow
> > which is wrong as well. The following should do the trick. Should I
> > split that into two patches?
> 
> Well, xfs_alloc_buftarg() needs to be more careful.
[...]
>         btp = kmem_zalloc(sizeof(*btp), KM_SLEEP | KM_NOFS); // This is GFP_NOFS context. But...
[...]
>         if (list_lru_init(&btp->bt_lru)) // This is GFP_KERNEL context.

this sounds like a separate thing to cleanup or document.
-- 
Michal Hocko
SUSE Labs