linux-kernel - Re: [PATCH] frv: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511457437.32422.6.camel@synopsys.com>
Date:   Thu, 23 Nov 2017 17:17:19 +0000
From:   Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:     "sudipm.mukherjee@...il.com" <sudipm.mukherjee@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Vineet Gupta" <Vineet.Gupta1@...opsys.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH] frv: fix build failure

Hi Sudip,

On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
> The frv defconfig build is failing with the error:
> lib/mpi/mpih-div.o: In function `mpihelp_divrem':
> mpih-div.c:(.text+0x30c): undefined reference to `abort'
> 
> The function 'abort' was never defined for the frv architecture.
> Create 'abort' as is done in other arch like 'arm' and 'unicore32'.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> ---

I'm seeing the same issue building for ARC from today's Linus' tree.
Maybe it worth implementing abort() as a weak function for every arch/platform
that doesn't have it explicitly defined? Otherwise we'll end-up with
useless code duplication.

-Alexey